Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed vacuum from name #240

Merged
merged 3 commits into from
Apr 21, 2022
Merged

removed vacuum from name #240

merged 3 commits into from
Apr 21, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

This PR removes the word "vacuum" from the name of components.
so componets like "vacuum_vessel" have been renamed "vessel"
This is useful as the name of components is used when making DAGMC tags
DAGMC tags including the word vacuum anywhere in the tag will treat the material as a vacuum.
svalinn/DAGMC#805 (comment)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #240 (096fce8) into develop (33250ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 096fce8 differs from pull request most recent head 1d944f2. Consider uploading reports for the commit 1d944f2 to get more accurate results

@@           Coverage Diff            @@
##           develop     #240   +/-   ##
========================================
  Coverage    95.29%   95.29%           
========================================
  Files           82       82           
  Lines         5508     5508           
========================================
  Hits          5249     5249           
  Misses         259      259
Impacted Files Coverage Δ
...amak/parametric_components/dished_vacuum_vessel.py 82.05% <ø> (ø)
...mak/parametric_reactors/flf_system_code_reactor.py 100.00% <ø> (ø)
...ametric_reactors/negative_triangularity_reactor.py 89.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33250ac...1d944f2. Read the comment docs.

@shimwell
Copy link
Member Author

Finally got the code linting working again 🎉

@shimwell shimwell merged commit 4764c20 into develop Apr 21, 2022
@shimwell shimwell deleted the removing_vacuum_from_name branch April 21, 2022 10:29
@shimwell shimwell mentioned this pull request Apr 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shimwell